- Correct Go version anchor: 1.24 -> 1.26 (matches go.mod).
- Drop ValidateFunc everywhere; ValidateDiagFunc only (ValidateFunc is
  deprecated and not allowed in this repo).
- Rewrite docs.instructions.md to target templates/** instead of the
  no-longer-existing website/**. Docs under docs/** are auto-generated;
  edits go in templates/, examples/, or resource Description fields.
- Replace remaining website/ references in copilot-instructions.md with
  docs/ and templates/.
- Add repository-rename convention to schema-and-state.instructions.md:
  attribute must be 'repository' (not ForceNew), plus computed
  'repository_id', plus CustomizeDiff: diffRepository.
- Add Delete 404 handling: treat as success, not error.
- Require *Context CRUD variants and diag.Diagnostics on all new
  resources.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add a 'terraform-plugin-testing Conventions' section to
.github/instructions/tests.instructions.md covering:

- Prefer ConfigStateChecks over the legacy Check /
  ComposeTestCheckFunc pattern.
- Use ValueComparers (compare.ValuesSame / compare.ValuesDiffer) for
  cross-step value comparisons instead of custom pointer structs.
- Don't flag legacy patterns in unmodified tests; only in new or
  substantially modified ones.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Incorporates the upstream Go instructions from
https://github.com/github/awesome-copilot/blob/main/instructions/go.instructions.md
as a path-scoped instructions file (applyTo: **/*.go,**/go.mod,**/go.sum).

A preamble subordinates the Go guidance to the repo's existing severity
policy (HIGH/MEDIUM only, no LOW or nits) and notes the Go-version
anchors in copilot-instructions.md plus the no-read-after-write
exception, so CCR doesn't suddenly start surfacing style nits or fight
provider-specific conventions.

The main copilot-instructions.md now lists every path-scoped file so
the set is discoverable.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>

Path-specific instruction files now cross-link to copilot-instructions.md
(and to go.instructions.md from the Go-scoped files), with several
content fixes on top.

docs.instructions.md
- Add a 'How Doc Generation Works' section explaining tfplugindocs,
  the templates/examples/schema layout, and the default-template
  fallback.
- Add a 'Local Doc Workflow' section calling out make generatedocs,
  make validatedocs, make checkdocs, and the rumdl targets.
- Rewrite the schema-sync section as 'fix forward' guidance: fix
  descriptions at the schema or template source, not in the generated
  docs/.
- Soften the Imports section: tfplugindocs auto-generates the import
  section from examples/resources/<name>/import.sh, so reviewers just
  need to verify that section renders.
- Recommend linking to the GitHub REST API reference for permission
  and scope info to avoid stale documentation.
- Note that terraform fmt is the formatting baseline for example HCL.
- Add a relative-link example for internal doc cross-references.

examples.instructions.md
- Distinguish the two kinds of example: single-file tfplugindocs
  snippets (under examples/{provider,resources,data-sources}/) and
  root-module examples (everything else). Standard-module-structure
  rules now apply only to root-module examples.
- Call out that tfplugindocs snippets must not declare
  required_providers or a provider block.

schema-and-state.instructions.md, tests.instructions.md
- Add cross-references to go.instructions.md.

schema-and-state.instructions.md
- Replace the ListOptions/NextPage pagination guidance with a
  recommendation to use the *Iter methods on google/go-github that
  return iter.Seq2[T, error]. Hand-rolled NextPage loops in existing
  code are still acceptable, but flag new code that re-implements
  pagination when an *Iter method exists.

go.instructions.md
- Add a short intro paragraph above the existing callout that links
  to copilot-instructions.md and the other path-scoped files.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

go.instructions.md
- Switch the applyTo glob from comma-separated to brace expansion
  ('**/{*.go,go.mod,go.sum}'). Brace expansion is universally
  minimatch-compatible, so this removes any doubt about whether the
  Go instructions actually apply to .go / go.mod / go.sum files.

copilot-instructions.md
- Resolve the conflict between 'ALWAYS acknowledge instructions are
  being used' and 'must say only No blocking findings found and stop'.
  Reviews with findings open with a dedicated acknowledgment sentence;
  reviews with no findings collapse the two requirements into one
  verbatim sentence:
  'These provider review instructions are being used. No blocking findings found.'

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CCR caught two factual errors in the previous round:

- examples/provider/provider.tf does not exist in this repo. The
  provider landing page (templates/index.md.tmpl) embeds
  examples/example_*.tf from the root of examples/ instead.
- The flat 'no required_providers / no provider block in tfplugindocs
  snippets' rule contradicts the landing-page snippets, which
  intentionally include both because the landing page is the first
  thing users see.

docs.instructions.md
- Updated the 'Example HCL under examples/' list in 'How Doc
  Generation Works' to reflect the real layout: example_*.tf at the
  root for the landing page (with required_providers + provider),
  and per-resource / per-data-source snippets under
  examples/resources/<name>/ and examples/data-sources/<name>/
  without those blocks.

examples.instructions.md
- Same correction in 'Two Kinds of Examples'.
- Provider Configuration bullet now scopes the 'no
  required_providers / no provider block' rule to per-resource and
  per-data-source snippets, with an explicit carve-out for the
  examples/example_*.tf landing-page snippets.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CCR pointed out that schema-and-state.instructions.md applies to
'github/**/*.go', which also matches '_test.go' files, creating an
overlap with tests.instructions.md.

Minimatch does not support negation globs without an explicit
'negate: true' option (the '!' prefix is ignored by default), so I
can't reliably narrow the applyTo to exclude '_test.go'. Instead I
spell out the precedence in the file itself: on test files,
tests.instructions.md is authoritative and the schema / CRUD /
API-safety bullets here are background, to be flagged only when the
test actually touches that code (e.g., hand-rolled pagination in an
acceptance test).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>